Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ENH: reference workflow N4 improvements #40

Merged
merged 11 commits into from
Dec 14, 2021

Conversation

eilidhmacnicol
Copy link
Collaborator

@eilidhmacnicol eilidhmacnicol commented Nov 17, 2021

Changes proposed in this pull request

This makes the rodent-specific arguments (made available by nipreps/niworkflows#630) available to the reference workflow for more robust N4 correction. This should make the reference image easier to mask.

Also worth noting that in this scenario, brain extraction is run only once (on the structural image), and the registration between structural and functional is run without masking.

Also updated FLIRTRPT to include --basescale 1 argument, based on the conversation had over at nipreps/fmriprep#2624, to overcome problems in coregistration when testing locally.
EDIT: this has been removed and will be added to a separate PR

Documentation that should be reviewed

@eilidhmacnicol eilidhmacnicol changed the title PIN: niworkflows feature branch ENH: reference workflow N4 improvements Nov 17, 2021
@eilidhmacnicol eilidhmacnicol force-pushed the pin/niworkflows_feature branch from 5707778 to 6f6a351 Compare November 17, 2021 18:56
@eilidhmacnicol eilidhmacnicol marked this pull request as ready for review November 23, 2021 18:13
Copy link
Member

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall

this will be added as a second PR
@eilidhmacnicol eilidhmacnicol merged commit 2ecfed5 into nipreps:master Dec 14, 2021
@eilidhmacnicol eilidhmacnicol deleted the pin/niworkflows_feature branch December 14, 2021 09:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants