-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ENH: reference workflow N4 improvements #40
Merged
eilidhmacnicol
merged 11 commits into
nipreps:master
from
eilidhmacnicol:pin/niworkflows_feature
Dec 14, 2021
Merged
ENH: reference workflow N4 improvements #40
eilidhmacnicol
merged 11 commits into
nipreps:master
from
eilidhmacnicol:pin/niworkflows_feature
Dec 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5707778
to
6f6a351
Compare
oesteban
approved these changes
Dec 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall
this will be added as a second PR
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
This makes the rodent-specific arguments (made available by nipreps/niworkflows#630) available to the reference workflow for more robust N4 correction. This should make the reference image easier to mask.
Also worth noting that in this scenario, brain extraction is run only once (on the structural image), and the registration between structural and functional is run without masking.
Also updatedFLIRTRPT
to include--basescale 1
argument, based on the conversation had over at nipreps/fmriprep#2624, to overcome problems in coregistration when testing locally.EDIT: this has been removed and will be added to a separate PR
Documentation that should be reviewed