ENH: Consider warnings as errors when running pytest
#40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhlegarreta
force-pushed
the
ConsiderWarningsAsErrorsInCI
branch
3 times, most recently
from
9ba5324 to
57398b0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
=======================================
Coverage 65.74% 65.74%
=======================================
Files 19 19
Lines 940 940
Branches 120 120
=======================================
Hits 618 618
Misses 278 278
Partials 44 44 ☔ View full report in Codecov by Sentry. |
|
Warnings are being filtered,
Working:
PR #39 solves the warning at issue. Marking this as ready. |
Consider warnings as errors when running `pytest`: - Add the `warnings-as-errors` flag to `pytest` to consider warnings as errors. - Use an environment variable `NIFREEZE_WERRORS` in GHA workflow files to mark the corresponding workflows as treating warnings as errors. - Process the `pytest` session end to mark it as failed if warnings were present. Implementation drawn from DIPY. Filter two warnings that are being raised by the current tests: - Filter warnings related to GPR parameter optimal values being close to the boundary values raised by `scikit-learn`. - Filter warnings related to the b0 threshold value being updated in gradient table slicing raised by DIPY.
jhlegarreta
force-pushed
the
ConsiderWarningsAsErrorsInCI
branch
from
57398b0 to
5db55a6
Compare
This was referenced Jan 10, 2025
oesteban
approved these changes
Jan 14, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider warnings as errors when running
pytest:warnings-as-errorsflag topytestto consider warnings as errors.NIFREEZE_WERRORSin GHA workflow files to mark the corresponding workflows as treating warnings as errors.pytestsession end to mark it as failed if warnings were present.Implementation drawn from DIPY.
Filter two warnings that are being raised by the current tests:
scikit-learn.