Skip to content

MRG: Add auto offscreen mode #245

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 12, 2018
Merged

MRG: Add auto offscreen mode #245

merged 1 commit into from
Jul 12, 2018

Conversation

larsoner
Copy link
Contributor

Adds offscreen='auto' as the default, which will use the mlab.options.offscreen value.

@codecov-io
Copy link

codecov-io commented Jun 27, 2018

Codecov Report

Merging #245 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage   74.93%   74.96%   +0.03%     
==========================================
  Files           7        7              
  Lines        2474     2477       +3     
  Branches      493      494       +1     
==========================================
+ Hits         1854     1857       +3     
  Misses        447      447              
  Partials      173      173

@larsoner
Copy link
Contributor Author

@agramfort
Copy link
Contributor

what is it useful for?

@larsoner
Copy link
Contributor Author

For creating screenshots it's safer (sometimes on Linux you get junk images/screenshots in Mayavi with actual windows). With this I can do mlab.options.offscreen = True then stc.plot(...) without needing to add the explicit offscreen option to stc.plot.

@larsoner
Copy link
Contributor Author

(Arguably also we should have always respected the mlab.options value rather than defaulting to offscreen=False)

@agramfort
Copy link
Contributor

agramfort commented Jun 27, 2018 via email

@larsoner larsoner merged commit d79a650 into nipy:master Jul 12, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants