Skip to content

ENH: Add option to smooth to nearest #275

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 6 commits into from
Oct 15, 2019
Merged

Conversation

larsoner
Copy link
Contributor

Allows doing smoothing_steps='nearest' so you can see the patches of cortex like (not the most relevant example but gives the idea):

Screenshot from 2019-09-24 12-26-44

@mwaskom
Copy link
Member

mwaskom commented Sep 24, 2019

Maybe a better example use-case would be doing some kind of discrete labeling in low-res space and then propagating the labels to the high-res surface?

@larsoner
Copy link
Contributor Author

some kind of discrete labeling in low-res space and then propagating the labels to the high-res surface?

That's basically what a MNE inverse solution is, a low(er)-res subsampling of the high res surface and then when we plot we upsample.

Ultimately this might not even need an example, so I can revert it if need be. I'd rather not write a separate new one just for this.

@codecov
Copy link

codecov bot commented Sep 24, 2019

Codecov Report

Merging #275 into master will increase coverage by 0.35%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
+ Coverage   73.96%   74.31%   +0.35%     
==========================================
  Files           7        7              
  Lines        2535     2570      +35     
  Branches      511      514       +3     
==========================================
+ Hits         1875     1910      +35     
  Misses        482      482              
  Partials      178      178

@larsoner
Copy link
Contributor Author

Got the little indexing demons worked out, this is what the MEG one looks like with 'nearest'

https://281-1551431-gh.circle-artifacts.com/0/html/auto_examples/plot_meg_inverse_solution.html

Copy link
Contributor

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize we don't have a what's new page...

@mwaskom
Copy link
Member

mwaskom commented Sep 24, 2019

That's right — just the changes file that is usually the basis for a release announcement email.

@larsoner
Copy link
Contributor Author

That file only goes up to 0.8, and we've released 0.9 already. I guess we're a bit behind there. I can add a 0.9 and dev section here sometime today or tomorrow

@larsoner
Copy link
Contributor Author

Feast your eyes on the beautiful changelog:

https://282-1551431-gh.circle-artifacts.com/0/html/changes.html

@agramfort
Copy link
Contributor

agramfort commented Sep 24, 2019 via email

@larsoner larsoner merged commit 1fb7daf into nipy:master Oct 15, 2019
@larsoner larsoner deleted the nearest branch October 15, 2019 14:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants