[WIP] FIX: Ensure fsl.FIRST output paths are reliably determined

[mgxd]

Summary

Fixes #2872 .

List of changes proposed in this PR (pull-request)

Generates FIRST outputs in the same directory as out_file.

Acknowledgment

• (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

[codecov-io]

Codecov Report

Merging #2877 into master will decrease coverage by 0.02%.
The diff coverage is 20%.

@@            Coverage Diff             @@
##           master    #2877      +/-   ##
==========================================
- Coverage   67.51%   67.49%   -0.03%     
==========================================
  Files         343      343              
  Lines       43591    43597       +6     
  Branches     5422     5424       +2     
==========================================
- Hits        29431    29424       -7     
- Misses      13457    13465       +8     
- Partials      703      708       +5

Flag	Coverage Δ
#smoketests	50.17% <0%> (-0.32%)	⬇️
#unittests	64.94% <20%> (-0.03%)	⬇️

Impacted Files	Coverage Δ
nipype/interfaces/fsl/preprocess.py	82.04% <20%> (-0.56%)	⬇️
nipype/workflows/fmri/spm/preprocess.py	70.4% <0%> (-2.05%)	⬇️
nipype/utils/provenance.py	82.8% <0%> (-1.28%)	⬇️
nipype/pipeline/engine/nodes.py	84.19% <0%> (-0.34%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbf2c35...53c028b. Read the comment docs.

[effigies]

@RiaanZoetmulder Can you confirm that this resolves your issue?

[mgxd]

@effigies this isn't ready yet - have to debug something

[effigies]

@mgxd Just a reminder that the 1.1.9 deadline is approaching.

[mgxd]

@RiaanZoetmulder will test if this patch is even necessary over the weekend - feel free to push this back to next release

[mgxd]

this shouldn't be necessary - closing