[FIX] Changes the type of ConvertScalarImageToRGBInputSpec.mask_file from File to traits.Str #3364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile to traits.Str
Codecov Report
@@ Coverage Diff @@
## master #3364 +/- ##
=======================================
Coverage 65.22% 65.22%
=======================================
Files 308 308
Lines 40536 40536
Branches 5355 5355
=======================================
Hits 26439 26439
Misses 13022 13022
Partials 1075 1075
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
effigies
reviewed
Oct 13, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am very new at making PR's so please let me know if I missed something formal about the process. I read the contributors guideline and have run the
make check-before-commitandpre-commit.Summary
The problem is described in depth in the linked issue.
The
mask_fileofConvertScalarImageToRGBInputSpecis an optional argument of typeFilewith a default value of"none"andexists=True.In some cases, this causes workflows to crash, as the nipype file validation sees that no file name
"none"exists.#3363
Fixes
I propose changing the type to
traits.Str, since themask_fileinput to the commandline tool is either a string referencing an existing file, or the string"none". Looking at the inputspec, it seems a similar thing was done to another optional input:custom_color_map_file.Acknowledgment