fix: make comparing foodId work (#304)

it should use equal() method, but it doesn't work even though it compares same id
nishiki-tech · Feb 20, 2024 · f6a2297 · f6a2297
1 parent 9156a3e
commit f6a2297
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/backend/main/src/Group/Domain/Entities/Container.ts b/backend/main/src/Group/Domain/Entities/Container.ts
@@ -138,9 +138,7 @@ export class Container extends AggregateRoot<string, IContainerProps> {
 	 * @param foodId
 	 */
 	public removeFood(foodId: FoodId): Result<Container, ContainerDomainError> {
-		const foods = this.props.foods.filter((f) => {
-			if (!f.id.equal(foodId)) return true;
-		});
+		const foods = this.props.foods.filter((f) => f.id.id !== foodId.id);
 		if (foods.length === this.props.foods.length) {
 			return Err(
 				new ContainerDomainError(