Skip to content

BMI calculator example #130

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Oct 12, 2023
Merged

BMI calculator example #130

merged 2 commits into from
Oct 12, 2023

Conversation

lutaii
Copy link
Contributor

@lutaii lutaii commented Sep 24, 2023

What does this implement/fix? Explain your changes
BMI Calculator example

Does this close any currently open issues?
Issue #103

  • Where has this been tested?

    • iPhone 14 Pro

    • Pixel 3A

  • Target Platform:
    iOS/Android

  • Walkthrough:

@lutaii
Copy link
Contributor Author

lutaii commented Sep 24, 2023

Hey @nisrulz.
Please review my pull request.

Copy link
Owner

@nisrulz nisrulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments to address. This PR needs some work.

Additionally, also note

  • You need to add a link back in readme index
  • Update the package name

@lutaii lutaii requested a review from nisrulz October 2, 2023 08:24
@lutaii
Copy link
Contributor Author

lutaii commented Oct 2, 2023

Hey @nisrulz. Can you review my changes once again?

@lutaii
Copy link
Contributor Author

lutaii commented Oct 11, 2023

Hey @nisrulz
Can I merge this pr?

@nisrulz
Copy link
Owner

nisrulz commented Oct 12, 2023

Hi @lutaii I still need to take a look at this PR. I'll try to merge open PRs in the next 2-3 days.

@nisrulz nisrulz merged commit 36c8bed into nisrulz:develop Oct 12, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants