fix POI Bug 60197 - setSheetOrder doesn't update names scope #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Referenced POI source code version: POI 5.2.3 POI Bug Tracker issue: https://bz.apache.org/bugzilla/show_bug.cgi?id=60197 Tracked POI changes: - bug 60197: Workbook#setSheetOrder should update named range sheet indices https://svn.apache.org/repos/asf/poi/trunk@1763939 - sonar fixes - use assert in junit tests https://svn.apache.org/repos/asf/poi/trunk@1872397 - #65026 - Migrate tests to Junit 5 https://svn.apache.org/repos/asf/poi/trunk@1884783
9rnsr
force-pushed
the
Workbook_SetSheetOrder
branch
from
6063eed to
d03dff9
Compare
|
LGTM |
|
Thank you! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #931. In practice, I've encountered it too when I tried to change sheet order after setting PrintArea in each sheets.
Referenced POI source code version: POI 5.2.3
POI Bug Tracker issue:
https://bz.apache.org/bugzilla/show_bug.cgi?id=60197
Tracked POI changes:
bug 60197: Workbook#setSheetOrder should update named range sheet indices
https://svn.apache.org/repos/asf/poi/trunk@1763939
sonar fixes - use assert in junit tests
https://svn.apache.org/repos/asf/poi/trunk@1872397
#65026 - Migrate tests to Junit 5
https://svn.apache.org/repos/asf/poi/trunk@1884783
(comment: Actual logic fix was only in first revision, rests were test code adjustments.)