Build process maintenance #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the key file npoi.snk upto the root of repository, then refer it from each csproj files.
Each csproj files are already migrated to use the PackageReference mode.
|
LGTM |
8 tasks
|
Thanks! I opened #1033 which describes why I started to maintain build process. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to understand about the NPOI build process, I found some weird files and build settings in the repository. This PR is small build process maintenance.
Share one assembly sign key file between projects
There were many same
npoi.snkfiles in the repository.Move the key file up to the root of repository, then refer it from each csproj files.
Remove unused assembly sign key file pk.snk
It's not used anywhere.
Remove unused
packages.configfilesEach csproj files are already migrated to use the PackageReference mode.