Advance XWPF functionalities to POI 3.16 #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From: > Fix bug 61787, which was introduced by bug 58067: Change how deleted content is detected to not incorrectly see too much text as deleted. > https://svn.apache.org/viewvc?view=revision&revision=1819405 In NPOI, original 61787 issue was fixed in dba2bc3, but tika-792 test case was left unfixed and had broke.
In Java, CT_RPr.sz.val was BigInteger, so the value -1 * 2 == -2 could be stored successfully, and later getFontSize() would return CT_RPr.sz.val / 2.0 == -1. However, storing -2 CT_RPr.sz.val didn't seem appropriate in OOXML spec (the minimum value of ST_HpsMeasure is 2, see https://learn.microsoft.com/en-us/openspecs/office_standards/ms-oi29500/2d0bf5fa-cdf4-4e5f-9a49-d3b3e0a2a35c), So I added *guard if* statement in FontSize setter to fix test failure in NPOI.
Bug 56076 - Add document protection with password support to XWPF Bug 56077 - Add password hash function to HWPF https://svn.apache.org/viewvc?view=revision&revision=1570750
Avoid two possible file-handle leaks when opening files fails with an exception Make tests close resources properly to not spam the output when running with file-leak-detector https://svn.apache.org/viewvc?view=revision&revision=1763485
Task-Url: https://bz.apache.org/bugzilla/show_bug.cgi?id=57366 This update contains a breaking change https://svn.apache.org/viewvc?view=revision&revision=1767175
…e TODOs on improving it, inspired by users@ discussions https://svn.apache.org/viewvc?view=revision&revision=1768005
https://svn.apache.org/viewvc?view=revision&revision=1768048 POI-60341, add test document (ugh, mea culpa), turn on test. https://svn.apache.org/viewvc?view=revision&revision=1768505
…setRepeatHeader does not overwrite old value Task-Url: https://bz.apache.org/bugzilla/show_bug.cgi?id=60337 https://svn.apache.org/viewvc?view=revision&revision=1768153
#54916 - POI does not always read all the slides in pptx files https://svn.apache.org/viewvc?view=revision&revision=1723966
- remove orphaned classes immediately, which are quite likely not used anymore - deprecated the rest https://svn.apache.org/viewvc?view=revision&revision=1774842
…exception to not have catch inside catch https://svn.apache.org/viewvc?view=revision&revision=1775118
cleanup sources - add parenthesis to statements https://svn.apache.org/viewvc?view=revision&revision=1778955
…hould return null if valign is not set. Patch from prasad-babu. This closes nissl-lab#30 on GitHub. apache/poi#30 (comment) https://svn.apache.org/viewvc?view=revision&revision=1782130
…Cell#getVerticalAlignment() returns null rather than a default value (XWPFVertAlign.TOP) if vertical alignment is not set https://svn.apache.org/viewvc?view=revision&revision=1782225
|
I fixed merge conflicts. |
|
I'm thinking if I should merge this PR to master or a test branch. This looks to be a big PR |
|
I'm paying attentions that any unit test failures will not increase by this PR. The purpose of this PR is making NPOI closer to POI. As you see the log messages of each commits, these are corresponding to POI bug fixes. That's why I didn't split this PR into many small PRs. Feel free to use test branch for the production quality of NPOI. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The baseline of POI version was 3.15, done by #290.
So I ported all commits related to XWPF from 3.15 until POI 3.16.