Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update Text.cs to handle StringEval in arg0 #1131

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

fred2020-net
Copy link
Contributor

In excel, this text function can also be used with strings (not only numeric values)

fred2020-net and others added 2 commits July 26, 2023 16:29
In excel, this text function can also be used with strings (not only numeric values)
@tonyqus
Copy link
Member

tonyqus commented Jul 26, 2023

Instead of removing the test case, can you update it to the correct one?

@tonyqus tonyqus added this to the NPOI 2.7.0 milestone Jul 26, 2023
@fred2020-net
Copy link
Contributor Author

Thanks @tonyqus for your feedback. The test is updated now.

@tonyqus
Copy link
Member

tonyqus commented Jul 27, 2023

LGTM

@tonyqus tonyqus merged commit 8b745fb into nissl-lab:master Jul 27, 2023
@tonyqus tonyqus modified the milestones: NPOI 2.7.0, NPOI 2.6.2 Aug 23, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants