Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove reflections on enums & dereference Enums.NET #1156

Merged
merged 7 commits into from
May 8, 2024
Merged

Remove reflections on enums & dereference Enums.NET #1156

merged 7 commits into from
May 8, 2024

Conversation

karakasa
Copy link
Contributor

Prepare NPOI for AOT, p1.

@karakasa karakasa marked this pull request as draft August 12, 2023 05:28
@karakasa karakasa mentioned this pull request Aug 12, 2023
Merged
@karakasa karakasa changed the title Remove reflections on enums & dereferencing Enums.NET Remove reflections on enums & dereference Enums.NET Aug 12, 2023
@karakasa karakasa marked this pull request as ready for review August 12, 2023 06:11
@tonyqus
Copy link
Member

tonyqus commented Aug 12, 2023

Why dereference Enums.NET? Is it using reflection?

@karakasa
Copy link
Contributor Author

Yes. And the lib isn't annotated with AOT attributes so the trimmer cannot preserve enums' metadata.

https://github.com/TylerBrinkley/Enums.NET/blob/a35664d000fb3e7c4f75ec303b8dc419837ab0d4/Src/Enums.NET/Enums.cs#L106C1-L110C7

@tonyqus tonyqus changed the base branch from master to aot August 13, 2023 14:17
@tonyqus tonyqus added this to the NPOI 2.7.1 milestone Aug 13, 2023
@tonyqus tonyqus added the aot label Aug 17, 2023
@tonyqus tonyqus removed this from the NPOI 2.7.1 milestone May 4, 2024
@tonyqus tonyqus merged commit c9f6c1e into nissl-lab:aot May 8, 2024
@tonyqus tonyqus added this to the NPOI vNext milestone May 8, 2024
@karakasa karakasa deleted the remove_reflection_enums branch May 8, 2024 10:30
@tonyqus tonyqus modified the milestones: NPOI vNext, NPOI AOT May 9, 2024
@tonyqus tonyqus mentioned this pull request Jul 10, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
aot
Projects
None yet
Milestone
NPOI AOT
Development

Successfully merging this pull request may close these issues.
2 participants
@karakasa @tonyqus