Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix XSSFSheet.RemoveHyperlink method. #1171

Merged

Conversation

artem-iron
Copy link
Contributor

The method wasn't removing the hyperlinks from CT_Hyperlinks array, only from a list in the hyperlinks property. Now it removes the hyperlink in both places.

Related to #1128

Updated the test for #690 to make sure the correct link is removed by the method.

@tonyqus tonyqus added this to the NPOI 2.6.2 milestone Aug 24, 2023
@tonyqus tonyqus added bug file_error file format generation/writing issue xlsx labels Aug 24, 2023
Copy link
Collaborator

@Bykiev Bykiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonyqus tonyqus merged commit b5f312f into nissl-lab:master Aug 24, 2023
@tonyqus
Copy link
Member

tonyqus commented Aug 24, 2023

cherry-pick to release 2.6.2 branch is done.

@artem-iron artem-iron deleted the fix-xssfsheet-removehyperlink branch August 25, 2023 03:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug file_error file format generation/writing issue xlsx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants