Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

More patches ported from poi 3.16 #1342

Merged
merged 14 commits into from
May 21, 2024
Merged

Conversation

antony-liu
Copy link
Collaborator

More patches ported from poi 3.16

@antony-liu antony-liu requested review from Bykiev and tonyqus May 8, 2024 12:31
@tonyqus
Copy link
Member

tonyqus commented May 19, 2024

Tests failed. Can you check the problem?

@antony-liu
Copy link
Collaborator Author

The test TestXSSFWorkbook.TestSetVBAProject was passed on my local, but failed with PR action. So ignore this test to make PR action pass.

@tonyqus
Copy link
Member

tonyqus commented May 20, 2024

The error looks a bit weird. Is it possible it only occurs in chance? Let's remove the ignore tag and trigger it again

Error: ICSharpCode.SharpZipLib.Zip.ZipException : EOF in header
  10:28:45 [DBG] 
  10:28:45 [DBG]   Failed TestSetVBAProject [11 ms]
  10:28:45 [DBG]   Error Message:
  10:28:45 [DBG]    ICSharpCode.SharpZipLib.Zip.ZipException : EOF in header
  10:28:45 [DBG]   Stack Trace:
  10:28:45 [DBG]      at ICSharpCode.SharpZipLib.Zip.Compression.Streams.InflaterInputBuffer.ReadLeByte()
  10:28:45 [DBG]    at ICSharpCode.SharpZipLib.Zip.ZipInputStream.SkipUntilNextEntry()
  10:28:45 [DBG]    at ICSharpCode.SharpZipLib.Zip.ZipInputStream.GetNextEntry()
  10:28:45 [DBG]    at NPOI.OpenXml4Net.Util.ZipInputStreamZipEntrySource..ctor(ZipInputStream inp) in /_/openxml4Net/Util/ZipInputStreamZipEntrySource.cs:line 35
  10:28:45 [DBG]    at NPOI.OpenXml4Net.OPC.ZipPackage..ctor(FileInfo file, PackageAccess access) in /_/openxml4Net/OPC/ZipPackage.cs:line 119
  10:28:45 [DBG]    at NPOI.OpenXml4Net.OPC.OPCPackage.Open(FileInfo file, PackageAccess access) in /_/openxml4Net/OPC/OPCPackage.cs:line 264
  10:28:45 [DBG]    at TestCases.XSSF.UserModel.TestXSSFWorkbook.TestSetVBAProject() in /_/testcases/ooxml/XSSF/UserModel/TestXSSFWorkbook.cs:line 907

@tonyqus tonyqus added this to the NPOI 2.7.1 milestone May 20, 2024
@antony-liu
Copy link
Collaborator Author

I have removed the ignore attribute, and the test passed.

@tonyqus
Copy link
Member

tonyqus commented May 21, 2024

LGTM

@tonyqus tonyqus merged commit 7110660 into nissl-lab:master May 21, 2024
3 checks passed
@antony-liu antony-liu deleted the poi/v3.16-patch5 branch December 21, 2024 08:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants