Fix XSSFExcelExtractor to emit empty cells #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default IRow enumerator will skip empty cells. This makes it so that the output from the Text property has cells that don't line up with their corresponding headers. This fix calls GetCell instead, which will return null in cases where the cell was empty. The tab delimiters work as expected now.
toddlucas
added a commit
to toddlucas/npoi
that referenced
this pull request
Jan 16, 2021
This fixes the issue addressed in PR nissl-lab#241 to emit a tab when an empty cell is encountered. Without it, any Excel file with an empty cell cannot be effectively parsed as CSV (TSV) since the cells don't line up with their expected columns. This fix does not affect any other tests.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default IRow enumerator will skip empty cells. This makes it so that the output from the Text property has cells that don't line up with their corresponding headers.
This fix calls GetCell instead, which will return null in cases where the cell was empty. The tab delimiters work as expected now.