Fix minValue and maxValue in SharedItems in CT_PivotCacheDefinition #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @tonyqus.
I'm sorry I've been gone so long. I don't see the point in writing an explanation. But I will try to at least close this issue. I analyzed the request from @solarding and found another inconsistency in the pivotCacheDefinition entry. I think that with this fix we can close this issue and solve the rest within the new Issue. And so the fix turned out to be very big.
I will continue to try to improve your project, as this topic is close to me.