Update Chart.cs #938
Merged
Update Chart.cs #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix for nissl-lab#930 and nissl-lab#376 : force invariant culture as non-english version of Excel expect "1.23" format for 1.23 double and the double->string conversion is dependent on current culture, resulting in "1,23" being generated in the XML.
|
LGTM |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #930 and #376 : force invariant culture as non-english version of Excel expect "1.23" format for 1.23 double and the double->string conversion is dependent on current culture, resulting in "1,23" being generated in the XML.
Ran the testsuite with no regressions on charts:
