Fixes internationalization bugs #930 #944 #376 #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested with 277 cultures successfully
PBrunot
changed the title
|
GetFilenameWithoutExtension is a very common and basic method. Please write unit tests against this method to make sure that it can work in different language/culture. |
Without the PR fix, this testcase fails in th-TH culture. With the PR fix, it passes and there are no regressions on other cultures.
|
Test case added, it fails on th-TH culture without the fix, and passes with the fix (StringComparison.Ordinal argument added). |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts previous incorrect #930 fix.
I have reproduced and tested #930 fix with .net core 6.0 version as follows:
I have used LineChart.cs example with 277 different locales and all files open fine on my italian Excel version.
The generated files are attached.
During this process I found a bug with locale th-TH which I fixed under #944
The ru-ru culture bug found, under #376 is also checked and fixed.
testlinechart-locales.zip