Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Able to open files with ill-formed datetime, exported by SAS #960

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

karakasa
Copy link
Contributor

@karakasa karakasa commented Nov 17, 2022

Fixed #846. Also added a basic test regarding SimpleDateFormat.Parse.

This fix is done by adding a compatibility stub into the aforementioned method allowing a leading space before one-digit hour instead of the regular zero.

Since the new approach utilizes DateTime.ParseExact, the change won't enable other ill-formed datetime strings.

@tonyqus
Copy link
Member

tonyqus commented Nov 17, 2022

It's nice to see a PR from a building architect.

一个被建筑设计耽误的程序员,哈哈

@tonyqus tonyqus merged commit 56cc2f7 into nissl-lab:master Dec 29, 2022
@karakasa karakasa deleted the allow_illformed_datetime_string branch December 29, 2022 04:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with opening xlsx files exported by SAS
2 participants