Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feature/tnp #205

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feature/tnp #205

wants to merge 1 commit into from

Conversation

som-04
Copy link
Contributor

@som-04 som-04 commented Jun 21, 2024

Fixes #14

@som-04 som-04 marked this pull request as ready for review June 23, 2024 11:09
Copy link
Contributor

@geekysilento geekysilento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

  • instead of jus adding a hyperlink, use a grid layout w 3 buttons as done in other pages

here is how we've used it in the departments page for reference, feel free to reuse its code:

image

Copy link
Member

@GetPsyched GetPsyched left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is overall in good shape and the page looks great. Good stuff!

i18n/translations.ts Outdated Show resolved Hide resolved
app/[locale]/training-and-placement/page.tsx Outdated Show resolved Hide resolved
app/[locale]/training-and-placement/page.tsx Outdated Show resolved Hide resolved
app/[locale]/training-and-placement/page.tsx Outdated Show resolved Hide resolved
app/[locale]/training-and-placement/page.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@geekysilento geekysilento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
this looks ugly, jus add it as badges under guidelines section imo

app/[locale]/training-and-placement/page.tsx Outdated Show resolved Hide resolved
app/[locale]/training-and-placement/page.tsx Outdated Show resolved Hide resolved
app/[locale]/training-and-placement/recruiters.ts Outdated Show resolved Hide resolved
app/[locale]/training-and-placement/page.tsx Outdated Show resolved Hide resolved
app/[locale]/training-and-placement/page.tsx Outdated Show resolved Hide resolved
app/[locale]/training-and-placement/page.tsx Outdated Show resolved Hide resolved
app/[locale]/training-and-placement/page.tsx Outdated Show resolved Hide resolved
app/[locale]/training-and-placement/page.tsx Outdated Show resolved Hide resolved
@heydoyouknowme0
Copy link
Contributor

what's left @som-04 ?
mergable?

@som-04
Copy link
Contributor Author

som-04 commented Jan 31, 2025

@heydoyouknowme0 it will be done soon,
the latest push was to update the list of companies.
once all the .pdf files are added to s3, and the paths are modified accordingly,
it will be ready. (few mins from now)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Training and Placement
4 participants