tool: revert log level of malformed gens #158
Conversation
|
Can you add a change to enable debugging logs in our tests? That would be great for diagnosing and fixing in the future. :) |
This reverts commit 4f18270.
The message about malformed generatiosn should semantically be a warning. However, since users might have hundres of old and thus malformed generations and can do little about it, this should remain a debug message. This way the user is not spammed with no-op warnings while still enabling debugging.
nikstur
force-pushed
the
revert-warnlevel-malformed-gen
branch
from
7995558 to
8efc061
Compare
This should already be enabled: https://github.com/nix-community/lanzaboote/blob/master/rust/tool/tests/common/mod.rs#L132 If you want to enable logging for the unit tests, we can take a look at: https://github.com/d-e-s-o/test-log |
|
Regarding the logging in unit tests: The more the better. But it looks like we are already doing that.
They can GC? Having lots of generations which users cannot boot, because lzbt can't parse them should be something that users should be aware of. We can make the warning less scary, if that's the issue, but it would be really valuable for diagnosing issues in the field. |
|
Eventually I want a single log message (warning) when there are malformed generations. But in the loop I do not think it makes sense to emit a warning for every malformed generation. If we implement what @alois31 suggested in the Matrix channel we can emit this warning when the GC does not run because there are broken generations. |
The message about malformed generations should semantically be a warning. However, since users might have hundreds of old and thus malformed generations and can do little about it, this should remain a debug message. This way the user is not spammed with no-op warnings while still enabling debugging.
This reverts the change to the log level made in #155