tool: only sync ESP filesystem #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilpner
commented
Aug 17, 2023
| @@ -161,7 +162,8 @@ impl Installer { | |||
| // Sync files to persistent storage. This may improve the | |||
| // chance of a consistent boot directory in case the system | |||
| // crashes. | |||
| sync(); | |||
| let boot = File::open(&self.esp_paths.esp).context("Failed to open ESP root directory.")?; | |||
| syncfs(boot.as_raw_fd()).context("Failed to sync ESP filesystem.")?; | |||
There was a problem hiding this comment.
I was going to format these two lines to match the other .context(...)? lines, but rustfmt disagrees.
|
Just a little pointer, switch-to-configuration.pl implements a variable |
|
Works on my machine. |
RaitoBezarius
approved these changes
Sep 13, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed lanzaboote was adding quite a bit of time to my nixos-rebuild time, and tracked it to the
sync()call. That currently syncs all filesystems, even if it only cares about the ESP filesystem. This commit opens the root directory of the ESP filesystem, passes it tosyncfsinstead, which should result in just syncing the ESP filesystem.