Lightweight Shell #245
Merged
Lightweight Shell #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikstur
requested changes
Oct 29, 2023
flake.nix
Outdated
| @@ -259,8 +243,6 @@ | |||
| config.packages.stub | |||
| config.packages.tool | |||
| ]; | |||
|
|
|||
| TEST_SYSTEMD = pkgs.systemd; | |||
There was a problem hiding this comment.
We should keep this around, otherwise you can't run the lzbt tests from the shell anymore.
There was a problem hiding this comment.
Good point. cargo test in lzbt passes now and I've also left openssl and sbctl.
RaitoBezarius
approved these changes
Oct 29, 2023
There was a problem hiding this comment.
LGTM modulo what @nikstur said.
Some of the tools are useful for us, developers, e.g. OpenSSL, sbctl overidden, etc. But it's fine I guess.
blitz
force-pushed
the
lightweight-shell
branch
from
ef512d6 to
3b12925
Compare
We are getting this warning: warning: some crates are on edition 2021 which defaults to `resolver = "2"`, but virtual workspaces default to `resolver = "1"` note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest Silence by opting into the new behavior.
blitz
force-pushed
the
lightweight-shell
branch
from
3b12925 to
3cb657f
Compare
|
@nikstur Can you check again? |
nikstur
approved these changes
Oct 30, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@phip1611 mentioned that our shell environment is pretty heavy and can compile for quite some time when entered. This PR drops everything from the shell environment that is not immediately useful for compile the Rust code or style checking.
While I was here, I also applied
cargo machetesuggestions.