Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(flake): perform final fixups to the flake outputs #257

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

RaitoBezarius
Copy link
Member

As flake-parts doesn't really support a concept of limited supported system (e.g. system for which we don't have CI), we need to fix up the final outputs to move the unsupported checks to another place where CI won't run them.

As flake-parts doesn't really support a concept of limited supported system (e.g. system for which
we don't have CI), we need to fix up the final outputs to move the unsupported checks to another place
where CI won't run them.
@blitz
Copy link
Member

blitz commented Nov 10, 2023

Hercules CI also succeeded after I massage it a bit.

Copy link
Member

@blitz blitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's as good as it gets. 🤷 Better than the hanging jobs in the CI. But I feel there are feature requests here for both flake-parts and Hercules CI. :)

@RaitoBezarius
Copy link
Member Author

@blitz Planning to send a PR to flake-parts for supporting the concept of "limited supported systems", but I fear this looks like a Flake limitation, like there's a whole to design here.

@RaitoBezarius RaitoBezarius added this pull request to the merge queue Nov 10, 2023
Merged via the queue into master with commit 81975f3 Nov 10, 2023
@RaitoBezarius RaitoBezarius deleted the aarch64-ci branch November 10, 2023 14:23
@nikstur
Copy link
Member

nikstur commented Nov 10, 2023

@blitz Planning to send a PR to flake-parts for supporting the concept of "limited supported systems", but I fear this looks like a Flake limitation, like there's a whole to design here.

Almost as if there should be a separation between default.nix and ci.nix ;)

@RaitoBezarius
Copy link
Member Author

@blitz Planning to send a PR to flake-parts for supporting the concept of "limited supported systems", but I fear this looks like a Flake limitation, like there's a whole to design here.

Almost as if there should be a separation between default.nix and ci.nix ;)

well, default.nix should definitely have ci = import ./ci.nix :-). inchallah flake schemas happen fast enough…

@blitz blitz mentioned this pull request Nov 23, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants