linux-bootloader: simplify get_loader_features #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than calling get_variable_size, allocating a vec, and then reading into it, use a fixed-size buffer. The behavior is unchanged, just a little simpler. Also added a summary of the error behavior to the docstring.
nicholasbishop
force-pushed
the
bishop-simplify-get-loader-features-2
branch
from
0104987 to
98cf650
Compare
|
CI is failing, but I'm unclear if it's related to my changes or something else. |
|
I kicked the CI again, seems CI instability. It feels like it should pass. |
RaitoBezarius
approved these changes
Oct 6, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than calling get_variable_size, allocating a vec, and then reading into it, use a fixed-size buffer. The behavior is unchanged, just a little simpler.
Also added a summary of the error behavior to the docstring.