Use ambient Nix when available, with a two stage fallback #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Aug 21, 2024
| prologue = | ||
| (writeText "prologue.sh" '' | ||
| NIX_DIRENV_SKIP_VERSION_CHECK=1 | ||
| NIX_DIRENV_FALLBACK_NIX=''${NIX_DIRENV_FALLBACK_NIX:-${lib.getExe nix}} |
There was a problem hiding this comment.
Can you mention this environment variable in the README? Otherwise it looks good to me.
K900
force-pushed
the
ambient-nix-with-fallback
branch
from
8494447 to
d7803d9
Compare
First, we try to use the ambient Nix version. Then, we try to use $NIX_DIRENV_FALLBACK_NIX, which is set by default, but can also be overridden by the user. Only then, if neither is available, we fail. Fixes nix-community#451.
K900
force-pushed
the
ambient-nix-with-fallback
branch
from
d7803d9 to
94def84
Compare
|
@mergify queue |
🛑 The pull request has been merged manuallyThe pull request has been merged manually at a3139c8 |
|
Is it just broken now...? |
"required checks" in mergify.yml needs an update. |
13 tasks
13 tasks
9999years
added a commit
to 9999years/nixpkgs
that referenced
this pull request
Sep 4, 2024
Upstream recently changed their resholve solutions somewhat to support using the ambient Nix on the user's `$PATH` or falling back to the default nixpkgs stable `nix` otherwise. Let's update our definitions to match. See: nix-community/nix-direnv#513
lf-
pushed a commit
to lf-/nixpkgs
that referenced
this pull request
Oct 14, 2024
Upstream recently changed their resholve solutions somewhat to support using the ambient Nix on the user's `$PATH` or falling back to the default nixpkgs stable `nix` otherwise. Let's update our definitions to match. See: nix-community/nix-direnv#513 (cherry picked from commit ea8ab50)
presto8
pushed a commit
to presto8/nixpkgs
that referenced
this pull request
Oct 24, 2024
Upstream recently changed their resholve solutions somewhat to support using the ambient Nix on the user's `$PATH` or falling back to the default nixpkgs stable `nix` otherwise. Let's update our definitions to match. See: nix-community/nix-direnv#513 (cherry picked from commit ea8ab50)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, we try to use the ambient Nix version.
Then, we try to use $NIX_DIRENV_FALLBACK_NIX, which is set by default, but can also be overridden by the user.
Only then, if neither is available, we fail.
Fixes #451.