Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

use ssh args for getting connection settings #228

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

mibmo
Copy link
Contributor

@mibmo mibmo commented Sep 23, 2023

fixes args such as --ssh-port not affecting the whole program (specifically the keyscan porting was impacting my setup)

tests seem to pass ok

@Mic92
Copy link
Member

Mic92 commented Sep 23, 2023

@mergify rebase

@Mic92 Mic92 force-pushed the fix/ssh-settings-args branch 2 times, most recently from 68ef836 to 18b1888 Compare September 23, 2023 17:46
@Mic92 Mic92 force-pushed the fix/ssh-settings-args branch from 18b1888 to aa86e68 Compare September 23, 2023 18:08
@Mic92
Copy link
Member

Mic92 commented Sep 23, 2023

@mergify queue

@mibmo
Copy link
Contributor Author

mibmo commented Sep 25, 2023

@mergify queue

I'm guessing this means it's getting merged, but is there a general eta? not at all important, just curious whether it's on the order of days, weeks, or months. To me this is a bug that makes nixos-anywhere literally unusable and I don't think my setup is too non-standard, just a different ssh port.

@Mic92
Copy link
Member

Mic92 commented Sep 25, 2023

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Sep 25, 2023

rebase

✅ Nothing to do for rebase action

@mergify
Copy link
Contributor

mergify bot commented Sep 25, 2023

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at bb058eb

@mergify mergify bot merged commit bb058eb into nix-community:main Sep 25, 2023
@Mic92
Copy link
Member

Mic92 commented Sep 25, 2023

@mergify queue

I'm guessing this means it's getting merged, but is there a general eta? not at all important, just curious whether it's on the order of days, weeks, or months. To me this is a bug that makes nixos-anywhere literally unusable and I don't think my setup is too non-standard, just a different ssh port.

Should be instant, but I had to re-enable it after migrating from numtide to the nix-community org.

@mibmo
Copy link
Contributor Author

mibmo commented Sep 25, 2023

@mergify queue

I'm guessing this means it's getting merged, but is there a general eta? not at all important, just curious whether it's on the order of days, weeks, or months. To me this is a bug that makes nixos-anywhere literally unusable and I don't think my setup is too non-standard, just a different ssh port.

Should be instant, but I had to re-enable it after migrating from numtide to the nix-community org.

Ahh, gotcha; no worries :) thanks for merging.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants