Prefer system rsync #243
Prefer system rsync #243
Conversation
This sets up the package derivation to prefer the system rsync in the same way the system SSH is preferred, to prevent issues that may arise (e.g. crashes) that can arise from mixing the system SSH with the derivation-provided rsync. Fixes #242.
|
PS: Not putting the updated lockfile in this one, but I'd imagine that this should also be shipped to nixpkgs even if it doesn't result in an actual version bump. |
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at bea2862 |
|
Are we sure that this has something to do with rsync/ssh not being compatible and not with this regression? NixOS/nixpkgs#265014 |
|
Seems like |
|
Hmm, yeah interesting! Admittedly for sure my only real need for rsync recently has been for nixos-anywhere, so if this is indeed the issue this can just be reverted - that'd fix the nixpkgs invocation too and the flake lockfile here could just be fast-forwarded when the build is fixed in nixpkgs/nixos-unstable. |
- Pin nixos-anywhere to prevent possible issues caused by upstream PR: nix-community/nixos-anywhere#243. Read more from the below nixpkgs issue: NixOS/nixpkgs#265014. - Fix the task.py usage instructions in README.md after #8. - Make `nix flake check` pre-push check less verbose. Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
|
I am currently working on a proper fix: #234 to fix rsync itself. |
- Pin nixos-anywhere to prevent possible issues caused by upstream PR: nix-community/nixos-anywhere#243. Read more from the below nixpkgs issue: NixOS/nixpkgs#265014. - Fix the task.py usage instructions in README.md after #8. - Make `nix flake check` pre-push check less verbose. Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
- Pin nixos-anywhere to prevent possible issues caused by upstream PR: nix-community/nixos-anywhere#243. Read more from the below nixpkgs issue: NixOS/nixpkgs#265014. - Fix the task.py usage instructions in README.md after tiiuae#8. - Make `nix flake check` pre-push check less verbose. Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
This sets up the package derivation to prefer the system rsync in the same way the system SSH is preferred, to prevent issues that may arise (e.g. crashes) that can arise from mixing the system SSH with the derivation-provided rsync.
Fixes #242.