Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix incorrect user explanation #345

Merged
merged 1 commit into from
Jul 14, 2024
Merged

fix incorrect user explanation #345

merged 1 commit into from
Jul 14, 2024

Conversation

jeremyschlatter
Copy link
Contributor

@jeremyschlatter jeremyschlatter commented Jul 6, 2024

Hello!

I just used nixos-anywhere for the first time. It went fairly smoothly except for this surprise this at the end of my logs:

### Waiting for the machine to become reachable again ###
ssh: connect to host 192.168.1.146 port 22: Connection refused
### Done! ###

It... "wait[ed] for the machine to become reachable again" only to stop immediately on a connection refused? Huh?

I looked through the nixos-anywhere source and it looks like this message is actually inverted -- we are waiting for the machine to become unreachable. I am deducing that from the fact that a previous step in the script that uses the same wait loop but says we are waiting for unreachability:

# wait for machine to become unreachable.
while timeout_ssh_ -- exit 0; do sleep 1; done

There also used to be a comment here that said unreachable before the user message that says reachable was added in 0997908:

Screenshot 2024-07-06 at 3 04 11 PM

This PR changes the message back to say unreachable.

See previous commit:

    0997908 print the various steps
@Mic92
Copy link
Member

Mic92 commented Jul 14, 2024

Thanks!

@Mic92
Copy link
Member

Mic92 commented Jul 14, 2024

@mergify queue

Copy link
Contributor

mergify bot commented Jul 14, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at daf19ef

@mergify mergify bot merged commit daf19ef into nix-community:main Jul 14, 2024
24 checks passed
@jeremyschlatter jeremyschlatter deleted the fix-explanation branch July 14, 2024 03:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants