nixos-anywhere: move unmount into reboot phase
#398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that users can now access the mounted filesystems by omitting
the `reboot` phase.
You can combine this with `--disko-mode mount` to mount and upgrade an
existing system before running `nixos-enter` to run commands on it.
$ nixos-anywhere --disko-mode mount --phases kexec,disko,install
|
We can add one, if requested. But I don't have a good use case for this in mind just now. |
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at b6168ba |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that users can now access the mounted filesystems by omitting the
rebootphase.You can combine this with
--disko-mode mountto mount and upgrade an existing system before runningnixos-enterto run commands on it.@Mic92 I wonder if it would be worth adding a separate
unmountphase