Skip to content

lib/types: maybeRaw should propagate elemType's sub-options #2341

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

lib/types: maybeRaw should propagate elemType's sub-options #2341

wants to merge 1 commit into from

Conversation

MattSturgeon
Copy link
Member

This is technically redundant, because we patch either to be recursive. But I think it is best if maybeRaw does this explicitly, without relying on that behaviour.

@MattSturgeon
Copy link
Member Author 

error: A definition for option `plugins.cmp.settings.sources' is not of type `list of (attribute set of anything)'. Definition values:
- In `/nix/store/a9v1l0scrw2nmsp7k40kywijf78mns6s-test-sources/plugins/cmp/default.nix':
    {
      __raw = ''
        cmp.config.sources({
          {
            {name = "path"},
    ...

I have no idea how this change could trigger that though...

MattSturgeon
MattSturgeon commented Nov 22, 2024
View reviewed changes
lib/types.nix
inherit (elemType)
getSubModules
getSubOptions
substSubModules
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a proper substSubModules is a little more complex than just re-using the elem-type's

@khaneliman khaneliman marked this pull request as draft January 31, 2025 23:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MattSturgeon