doc: fix simple flake example #3083
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elythh
force-pushed
the
readme-flake-example
branch
from
958999e to
574855e
Compare
elythh
changed the title
|
Something similar could also be used for the template |
There was a problem hiding this comment.
Looks good overall. Thanks!
FYI: your branch is ~27 commits behind the latest main. You may want to fetch our repo (probably your upstream remote), rebase onto it and force-push.
Also, could you change your commit message to something like readme: fix & simplify simple flake example ? We usually use the rough file/directory to scope our commit messages.
| nvim = nixvim'.makeNixvim config; | ||
| in { | ||
| packages = { | ||
| forAllSystems = fn: nixpkgs.lib.genAttrs systems fn; |
There was a problem hiding this comment.
Suggested change
| forAllSystems = fn: nixpkgs.lib.genAttrs systems fn; | |
| forAllSystems = nixpkgs.lib.genAttrs systems; |
|
|
||
| inputs.nixvim.url = "github:nix-community/nixvim"; | ||
| inputs = { | ||
| nixpkgs.url = "github:nixos/nixpkgs/nixpkgs-unstable"; |
There was a problem hiding this comment.
It may be better for us to suggest users use nixpkgs.follows = "nixvim/nixpkgs", at least for a flake that is just outputting nixvim packages and not also nixos configurations (etc):
Suggested change
| nixpkgs.url = "github:nixos/nixpkgs/nixpkgs-unstable"; | |
| nixpkgs.follows = "nixvim/nixpkgs"; |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the incorrect simple flake example from the README with a simpler one