Skip to content

Add getregs()/setregs()/getregset()/setregset() support for loongarch64-linux-gnu/musl #2507

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Fearyncess
Copy link
Contributor

@Fearyncess Fearyncess commented Sep 18, 2024

What does this PR do

This pull request will add ptrace reg funcs support for loongarch64 architectures, includes loongarch64-linux-gnu and loongarch64-linux-musl.

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

@Fearyncess Fearyncess force-pushed the loongarch64-ptrace-regs branch from 80550b6 to e29f356 Compare September 18, 2024 16:55
@Fearyncess
Copy link
Contributor Author

Fearyncess commented Sep 18, 2024

Maybe it should have #2461 merged if this PR could get a good test result on loongarch64 target.

@Fearyncess Fearyncess force-pushed the loongarch64-ptrace-regs branch from e29f356 to fdbf69b Compare September 18, 2024 17:00
@SteveLauC
Copy link
Member

Maybe it should have #2461 merged if this PR could get a good test result on loongarch64 target.

Yeah, you are welcome to pick it up if the author of that PR is ok with this.

@SteveLauC
Copy link
Member

Please rebase your branch to run the CI.

@Fearyncess Fearyncess force-pushed the loongarch64-ptrace-regs branch from fdbf69b to 531f0f9 Compare September 22, 2024 11:33
@Fearyncess
Copy link
Contributor Author

Please rebase your branch to run the CI.

rebased and updated.

@SteveLauC
Copy link
Member

Just foud an issue left by #2502, let's fix it first:)

@Fearyncess
Copy link
Contributor Author

Just foud an issue left by #2502, let's fix it first:)

Oops, maybe Rust universe needs more musl users. haha

@SteveLauC
Copy link
Member

maybe Rust universe needs more musl users. haha

Indeed 😪

@Fearyncess
Copy link
Contributor Author

It seems rust-lang/libc 0.2 will include these ptrace syscall in musl.
lemme add some CI on musl...

@SteveLauC
Copy link
Member

You mean aarch64/Linux/musl? I tried to do this in #2510, but barely have time to finish it now. 😮‍💨

@SteveLauC
Copy link
Member

Ok, #2510 is merged now

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants