feat: Get tcp_info structure
#2615
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement TCP_INFO option for getsockopt.
|
Hello, it looks like the CI is failing for two reasons:
The former is out of this PR's scope, so I won't address that here. However, I'd like advice on how to resolve the latter. Thank you! |
SteveLauC
reviewed
Mar 21, 2025
| @@ -1268,6 +1268,17 @@ sockopt_impl!( | |||
| libc::SO_EXCLBIND, | |||
| bool | |||
| ); | |||
| #[cfg(target_os = "linux")] | |||
There was a problem hiding this comment.
Hi there
However, I'd like advice on how to resolve the latter.
If uClibc has that symbol, you can add it to the libc crate. Otherwise, we need to filter it out:
Suggested change
| #[cfg(target_os = "linux")] | |
| #[cfg(all(target_os = "linux", not(target_env = "uclibc")))] |
SteveLauC
requested changes
Mar 21, 2025
Comment on lines
+1963
to
+1964
| - Added `TCP_INFO` sockopt to read TCP socket information on _linux_. | ||
| ([#2615](https://github.com/nix-rust/nix/pull/2615)) |
There was a problem hiding this comment.
Please add the changelog entry there: https://github.com/nix-rust/nix/tree/master/changelog
Will be addressed in #2610 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement TCP_INFO option for getsockopt.
What does this PR do
Checklist:
CONTRIBUTING.md