Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

hasNestedCollapse no longer necessary in v5 yet is used in Nested example #270

Closed
itsuryev opened this issue May 27, 2020 · 1 comment · Fixed by #285
Closed

hasNestedCollapse no longer necessary in v5 yet is used in Nested example #270

itsuryev opened this issue May 27, 2020 · 1 comment · Fixed by #285

Comments

@itsuryev
Copy link

Hello!

According to docs:

- ~~hasNestedCollapse~~ - no longer necessary, as v5 does not care if there are nested Collapse elements, see [example/App/Nested.js](example/App/Nested.js)

Yet that very file does use hasNestedCollapse prop.

As there is no such prop in implementation I guess it should be removed in example as well?
@nkbt
Copy link
Owner

nkbt commented May 27, 2020

I must have missed it in the example, yes it is definitely unnecessary

nkbt added a commit that referenced this issue Nov 19, 2020
@nkbt
Remove hasNestedCollapse from example as it not necessary
e8790b5 
Fixes #270
@nkbt nkbt mentioned this issue Nov 19, 2020
Merged
@nkbt nkbt closed this as completed in #285 Nov 19, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove hasNestedCollapse from example as it not necessary nkbt/react-collapse
2 participants
@nkbt @itsuryev