Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

BUG: Fix atom-pairs not being sorted if certain parameters are guessed #262

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

BvB93
Copy link
Member

@BvB93 BvB93 commented Jan 24, 2022

@BvB93 BvB93 added the bug Something isn't working label Jan 24, 2022
@BvB93 BvB93 self-assigned this Jan 24, 2022
@BvB93 BvB93 added this to the Auto-FOX 0.10.2 milestone Jan 24, 2022
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #262 (4256e17) into master (e27b09a) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   75.32%   75.35%   +0.03%     
==========================================
  Files          65       65              
  Lines        6958     6959       +1     
  Branches     1342     1339       -3     
==========================================
+ Hits         5241     5244       +3     
+ Misses       1382     1381       -1     
+ Partials      335      334       -1     
Impacted Files Coverage Δ
FOX/armc/package_manager.py 72.53% <100.00%> (-1.26%) ⬇️
FOX/armc/param_mapping.py 85.61% <100.00%> (+0.94%) ⬆️
FOX/armc/sanitization.py 89.85% <100.00%> (-0.08%) ⬇️
FOX/functions/cp2k_utils.py 50.00% <100.00%> (+1.72%) ⬆️
FOX/recipes/psf.py 84.08% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e27b09a...4256e17. Read the comment docs.

@BvB93 BvB93 merged commit 4a655ba into master Jan 24, 2022
@BvB93 BvB93 deleted the atom_order branch January 24, 2022 11:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant