Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

BUG: Fix the param columns being incorrectly written to the .hdf5 file #266

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

BvB93
Copy link
Member

@BvB93 BvB93 commented Feb 3, 2022

cc @RobertaPascazio

Note that this will change the output of FOX.from_hdf5(filename, datasets="param"),
as the latter will now return a list of dataframes.

@BvB93 BvB93 added the bug Something isn't working label Feb 3, 2022
@BvB93 BvB93 added this to the 0.10.2 milestone Feb 3, 2022
@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #266 (fa92490) into master (933242f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
- Coverage   75.26%   75.24%   -0.02%     
==========================================
  Files          66       66              
  Lines        7054     7058       +4     
  Branches     1355     1356       +1     
==========================================
+ Hits         5309     5311       +2     
  Misses       1408     1408              
- Partials      337      339       +2     
Impacted Files Coverage Δ
FOX/io/hdf5_utils.py 80.52% <100.00%> (+0.11%) ⬆️
FOX/testing_utils.py 71.33% <100.00%> (-0.97%) ⬇️
FOX/io/read_psf.py 80.11% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 933242f...fa92490. Read the comment docs.

@BvB93 BvB93 merged commit bd416d2 into master Feb 3, 2022
@BvB93 BvB93 deleted the param branch February 3, 2022 13:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant