Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

BUG: Fix only settings not being properly updated for PES-averaged ARMC #273

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

BvB93
Copy link
Member

@BvB93 BvB93 commented Mar 21, 2022

cc @RobertaPascazio

With PES-averaged ARMC only the parameters of the first job would previously be updated.

@BvB93 BvB93 added the bug Something isn't working label Mar 21, 2022
@BvB93 BvB93 added this to the 0.10.2 milestone Mar 21, 2022
@BvB93 BvB93 self-assigned this Mar 21, 2022
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #273 (83f15a3) into master (f7b2ed0) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
+ Coverage   75.25%   75.29%   +0.04%     
==========================================
  Files          66       66              
  Lines        7092     7092              
  Branches     1358     1358              
==========================================
+ Hits         5337     5340       +3     
+ Misses       1414     1413       -1     
+ Partials      341      339       -2     
Impacted Files Coverage Δ
FOX/armc/armc.py 85.30% <100.00%> (ø)
FOX/armc/armc_pt.py 87.60% <100.00%> (ø)
FOX/io/read_psf.py 80.11% <0.00%> (ø)
FOX/armc/monte_carlo.py 79.09% <0.00%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7b2ed0...83f15a3. Read the comment docs.

@BvB93 BvB93 merged commit 945b453 into master Mar 21, 2022
@BvB93 BvB93 deleted the err branch March 21, 2022 17:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant