Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ENH: Allow the .xyz parser to handle empty lines #277

Merged
merged 1 commit into from
Mar 30, 2022
Merged

ENH: Allow the .xyz parser to handle empty lines #277

merged 1 commit into from
Mar 30, 2022

Conversation

BvB93
Copy link
Member

@BvB93 BvB93 commented Mar 30, 2022

cc @maxsw2

Ensure that .xyz files with empty lines, such as the one below, are considered valid.

2
Frame 1
H 1.0 0.0 0.0
H 0.0 0.0 0.0

2
Frame 2
H 2.0 0.0 0.0
H 1.0 0.0 0.0


@BvB93 BvB93 added the enhancement New feature or request label Mar 30, 2022
@BvB93 BvB93 added this to the 0.10.2 milestone Mar 30, 2022
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #277 (3af6648) into master (11ad965) will decrease coverage by 0.03%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
- Coverage   75.32%   75.29%   -0.04%     
==========================================
  Files          66       66              
  Lines        7093     7076      -17     
  Branches     1358     1355       -3     
==========================================
- Hits         5343     5328      -15     
  Misses       1410     1410              
+ Partials      340      338       -2     
Impacted Files Coverage Δ
FOX/io/read_xyz.py 71.15% <57.14%> (+0.13%) ⬆️
FOX/armc/armc_pt.py 85.12% <0.00%> (-2.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11ad965...3af6648. Read the comment docs.

@BvB93 BvB93 linked an issue Mar 30, 2022 that may be closed by this pull request
Closed
@BvB93 BvB93 merged commit 4242644 into master Mar 30, 2022
@BvB93 BvB93 deleted the xyz branch March 30, 2022 22:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XYZ
1 participant