ENH: Add special casing for zero-division in the ARMC error func #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
==========================================
- Coverage 75.32% 75.07% -0.26%
==========================================
Files 66 66
Lines 7093 7104 +11
Branches 1358 1363 +5
==========================================
- Hits 5343 5333 -10
- Misses 1410 1434 +24
+ Partials 340 337 -3
Continue to review full report at Codecov.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @RobertaPascazio
The error functions will now return infinity instead of nan when 0-division occurs upon computing ARMC error functions. An exception is made for the special case wherein both operands are zero, in which case the resulting error will also be zero.