Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Let device send only FW version itself, not including prefix nor newline #183

Merged
merged 1 commit into from
Nov 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions device/PowerSensor/PowerSensor.ino
Original file line number Diff line number Diff line change
Expand Up @@ -278,12 +278,9 @@ void serialEvent() {
break;
case 'V':
// Send firmware version in human-readable format
Serial.print("Firmware version: ");
#ifdef DEMO
Serial.print(VERSION);
Serial.println("-DEMO");
#else
Serial.println(VERSION);
#ifdef DEMO
Serial.print("-DEMO");
#endif
break;
case 'Z':
Expand Down
3 changes: 1 addition & 2 deletions host/src/psconfig.cc
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,7 @@ void autoCalibrate() {


void print() {
// firmware version
std::cout << powerSensor->getVersion() << std::endl;
std::cout << "Device firmware version: " << powerSensor->getVersion() << std::endl;

PowerSensor3::State startState, stopState;

Expand Down
3 changes: 1 addition & 2 deletions host/src/psinfo.cc
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ void getPowerSensor(std::string device) {


void printInfo() {
// firmware version
std::cout << powerSensor->getVersion() << std::endl;
std::cout << "Device firmware version: " << powerSensor->getVersion() << std::endl;

PowerSensor3::State state = powerSensor->read();

Expand Down