Make marker use more robust #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so when no dumpfile is in use
Setting the marker bit is moved from the IRQ handler to the main loop. The data to send is copied to avoid the IRQ handler overwriting it before sending
loostrum
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The firmware used to set the marker bit in the DMA IRQ handler. When a new IRQ is triggered before data is sent, a marker could get lost.
Now, the marker bit is set in the main loop just before sending the data. To avoid the IRQ handler still overwriting the data to be sent (
serialDataobject), the data is copied before setting the marker bit and sending it.In the host library, any markers received from the device when a dumpfile is not open are rightfully ignored, but they weren't removed from the marker queue. That has been fixed.
The markers are now also written inline with the measurements, the marker character given to the mark function replaces the default
Sat the start of the line.Lastly, a minor comment error was fixed in the description of the timestamp packet in the firmware.