CSS relative path broken with some server DOCUMENT_ROOT settings #33

gs58muse · 2018-04-19T09:14:51Z

Hello Nicolas

something is going wrong on my LIVE-SYSTEM with the "RELPATH" Var.
The "style.css" is not called.
The Problem is in the Var: "$_SERVER['DOCUMENT_ROOT']"

MY XAMPP TEST-SYSTEM:
P01C\PATH: C:\xampp_5.6.24\htdocs\test\plugins\p01-contact/
DOCUMENT_ROOT: C:/xampp_5.6.24/htdocs
RELPATH: \test\plugins\p01-contact/

MY LIVE SYSTEM: (Provider 1+1 or also Profihost)
Path: /homepages/0/d109796559/htdocs/test/plugins/p01-contact/
DOCUMENT_ROOT: /kunden/homepages/0/d109796559/htdocs
RELPATH: lugins/p01-contact/

The only Workaround for me to make it run:
define('P01C\RELPATH', dirname(substr(PAGEURL, strlen(SERVER)))."/plugins/p01-contact/");

Greetings
Gerhard

nliautaud · 2018-04-19T11:08:25Z

Hi,
Thanks for the report.

Indeed, it seems that your $_SERVER['DOCUMENT_ROOT'] server setting root is different than the __FILE__ output one, breaking the RELPATH stripping, which is used for the css path.

I can't use your workaround (it seems to me that substr(PAGEURL, strlen(SERVER)) is equivalent to PAGEURI) : I can't define the relative path from the direct parent of the uri, as the uri may have multiple levels, ex /mysite/foo/bar/, and I can't hardcode /plugins, as the script may be used as standalone or on several CMS with different files structures.

As an example, the script has to handle :

URL : domain.com/some/cms/foo/bar/contact-page
PATH : /user/0/123456/http/some/cms/plugins/p01-contact/
RELPATH : /some/cms/plugins/p01-contact/

I can't either compare the strings and look for similarities without risking
false positives.

Unfortunately the only way I know is to rely on DOCUMENT_ROOT 😕 .

integratec · 2018-08-28T16:47:03Z

Hi,
same issue here (apache on debian, php 5.6). I solved ensuring a path separator exists when chaining SERVER and RELPATH constants.
In p01contact php starting at line 110:

       if (!$once) {
            $glue = '';
            if (RELPATH[0] != DIRECTORY_SEPARATOR) {
              $glue = '/';
            }
            $defaultStyle = '<link rel="stylesheet" href="' . SERVER . $glue . RELPATH . 'style.css"/>';
            $once = true;
        }

edit: changed to use DIRECTORY_SEPARATOR system constant in comparison insteaad of hardcoded slash.

nliautaud · 2018-08-29T10:25:32Z

Hi, thanks for the report.
Not sure if it's related or another issue.
Could you share your __FILE__, $_SERVER['DOCUMENT_ROOT'] and P01C\RELPATH values ?

integratec · 2018-08-29T11:32:19Z

Could you share your FILE, $_SERVER['DOCUMENT_ROOT'] and P01C\RELPATH values ?

__FILE__ : /var/www/plugins/p01-contact/src/P01contact.php
$_SERVER[DOCUMENT_ROOT] => /var/www/
[P01C\RELPATH] => plugins/p01-contact/

nliautaud · 2018-08-29T13:06:52Z

Thanks. The server is returning a valid document root, so it's a different cause.

Instead of a condition on newForm, I would normalize RELPATH to always start with a directory separator. Using '/' . ltrim(..., '/') on #L37 for example.

Would you make a Pull request ?

integratec · 2018-08-30T06:53:30Z

Instead of a condition on newForm, I would normalize RELPATH to always start with a directory separator.

Sure it's better, I was thinking about but led it unthouched to avoid breaking something else because confused by the constant name. Now I checked actually it's not used elsewere.

Would you make a Pull request ?

Actually not, also because i'm working on my local svn repository so I need first forking your git repo.

beejay41 · 2018-11-19T14:23:17Z

and it can get worse!
My document root is a symlink to the physical files location, so that I can organise my projects. Which means the length of "document root" is significantly shorter than __DIR__.
For GS I've patched with:
define('P01C\RELPATH', '/'.str_replace(GSROOTPATH, '', PATH));
Not sure if that's a general solution for you. I probably shouldn't be using symlinks for document roots.

nliautaud · 2018-11-19T16:32:36Z

@beejay41 indeed ! Could you test the PR #43 ? Tried a generalized way to get the root.

(@integratec @gs58muse too if possible)

gs58muse · 2018-11-19T18:01:16Z

Hi,
testet #43
define('P01C\RELPATH', substr(PATH, strlen($_SERVER['DOCUMENT_ROOT'])));
also:
define('P01C\RELPATH', '/'.str_replace(GSROOTPATH, '', PATH));
dont work for me.
I have to to it the hard way:
define('P01C\RELPATH', substr($SITEURL, strlen(SERVER)). "plugins/p01-contact/");

beejay41 · 2018-11-19T20:53:06Z

Yes, the "ROOT" solution works for me with my symlinks, and it avoids GS variable reliance.

Thanks,
Brian.

nliautaud · 2018-11-21T16:53:22Z

@gs58muse I didn't get if you tried the patch #43 SCRIPTNAME/SCRIPTPATH/ROOT solution (whitch doesn't rely on your DOCUMENT_ROOT setting) ? Could you give me the output of the constants in the debug report when using #43 ?

nliautaud · 2018-11-22T17:36:04Z

@beejay41 looks like a misunderstanding, I was asking gs58muse :) Thanks anyway, I deleted your reply as requested.

gs58muse · 2018-11-22T19:31:40Z

Hi Nicolas, Great - it works for me. The form will be displayed correctly The RELPATH is OK (the form will call the stylesheet correctly) Thanks @gs58muse <https://github.com/gs58muse> From: Nicolas Liautaud [mailto:notifications@github.com] Sent: Wednesday, November 21, 2018 5:53 PM To: nliautaud/p01contact <p01contact@noreply.github.com> Cc: gs58muse <gsms50@t-online.de>; Mention <mention@noreply.github.com> Subject: Re: [nliautaud/p01contact] CSS relative path broken with some server DOCUMENT_ROOT settings (#33) @gs58muse <https://github.com/gs58muse> I didn't get if you tried the patch #43 <#43> SCRIPTNAME/SCRIPTPATH/ROOT solution (whitch doesn't rely on your DOCUMENT_ROOT setting) ? Could you give me the output of the constants in the debug report when using #43 <#43> ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#33 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/Aj_oDBpA74vVYl9ODkpKqUvhQKmQBr8zks5uxYUCgaJpZM4TbbYx> . <https://github.com/notifications/beacon/Aj_oDIuCpAGOjo7bGHgFzBnQpj6P_8-Bks5uxYUCgaJpZM4TbbYx.gif> Health : PHP version : 7.1.24 PHP mbstring (UTF-8) : OK Constants : Array ( [P01C\VERSION] => 1.1.4 [P01C\SERVERNAME] => seipel.de [P01C\SERVERPORT] => 80 [P01C\SCRIPTNAME] => /gsdev/index.php [P01C\SCRIPTPATH] => /homepages/0/d109796559/htdocs/gsdev/index.php [P01C\HTTPS] => [P01C\PORT] => [P01C\PROTOCOL] => http [P01C\SERVER] => http://seipel.de [P01C\PAGEURI] => /gsdev/index.php?id=kontakt [P01C\PAGEURL] => http://seipel.de/gsdev/index.php?id=kontakt [P01C\PATH] => /homepages/0/d109796559/htdocs/gsdev/plugins/p01-contact/ [P01C\ROOT] => /homepages/0/d109796559/htdocs [P01C\RELPATH] => /gsdev/plugins/p01-contact/ [P01C\LANGSPATH] => /homepages/0/d109796559/htdocs/gsdev/plugins/p01-contact/lang/ [P01C\TPLPATH] => /homepages/0/d109796559/htdocs/gsdev/plugins/p01-contact/src/templates/ [P01C\CONFIGPATH] => /homepages/0/d109796559/htdocs/gsdev/plugins/p01-contact/config.json [P01C\LOGPATH] => /homepages/0/d109796559/htdocs/gsdev/plugins/p01-contact/log.json [P01C\REPOURL] => https://github.com/nliautaud/p01contact [P01C\WIKIURL] => https://github.com/nliautaud/p01contact/wiki [P01C\ISSUESURL] => https://github.com/nliautaud/p01contact/issues [P01C\APILATEST] => https://api.github.com/repos/nliautaud/p01contact/releases/latest )

nliautaud · 2018-11-23T11:33:46Z

Thanks everyone, will be shipped in the next release 👍

nliautaud added the bug label Apr 19, 2018

nliautaud changed the title ~~Problem with Var: RELPATH~~ CSS relative path broken with some server DOCUMENT_ROOT settings Apr 19, 2018

nliautaud mentioned this issue Nov 19, 2018

Fix css path breaking on some server configurations #43

Merged

Repository owner deleted a comment from beejay41 Nov 22, 2018

nliautaud self-assigned this Nov 22, 2018

nliautaud closed this as completed in eedd801 Nov 23, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CSS relative path broken with some server DOCUMENT_ROOT settings #33

CSS relative path broken with some server DOCUMENT_ROOT settings #33

gs58muse commented Apr 19, 2018

nliautaud commented Apr 19, 2018

integratec commented Aug 28, 2018 •

edited

Loading

nliautaud commented Aug 29, 2018

integratec commented Aug 29, 2018

nliautaud commented Aug 29, 2018

integratec commented Aug 30, 2018 •

edited

Loading

beejay41 commented Nov 19, 2018 •

edited

Loading

nliautaud commented Nov 19, 2018 •

edited

Loading

gs58muse commented Nov 19, 2018

beejay41 commented Nov 19, 2018

nliautaud commented Nov 21, 2018

nliautaud commented Nov 22, 2018

gs58muse commented Nov 22, 2018 via email

nliautaud commented Nov 23, 2018

CSS relative path broken with some server DOCUMENT_ROOT settings #33

CSS relative path broken with some server DOCUMENT_ROOT settings #33

Comments

gs58muse commented Apr 19, 2018

nliautaud commented Apr 19, 2018

integratec commented Aug 28, 2018 • edited Loading

nliautaud commented Aug 29, 2018

integratec commented Aug 29, 2018

nliautaud commented Aug 29, 2018

integratec commented Aug 30, 2018 • edited Loading

beejay41 commented Nov 19, 2018 • edited Loading

nliautaud commented Nov 19, 2018 • edited Loading

gs58muse commented Nov 19, 2018

beejay41 commented Nov 19, 2018

nliautaud commented Nov 21, 2018

nliautaud commented Nov 22, 2018

gs58muse commented Nov 22, 2018 via email

nliautaud commented Nov 23, 2018

integratec commented Aug 28, 2018 •

edited

Loading

integratec commented Aug 30, 2018 •

edited

Loading

beejay41 commented Nov 19, 2018 •

edited

Loading

nliautaud commented Nov 19, 2018 •

edited

Loading