Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add use-public-rspm = FALSE option to calc coverage. #113

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

k-doering-NOAA
Copy link
Collaborator

Addresses #110. The purpose is to allow users to specify use-public-rspm = FALSE in a workflow. This means that cran (not compiled for linux) packages will be used instead of posit package manager (compiled for linux). This is unlikely to be used, as the runs will be slower; however, there is a matrix bug that affects TMB dependencies that can be fixed by downloading from source instead of compiled packages.

The workflow would look like this:

# call a workflow that runs covr::codecov() to calculate code coverage
name: call-calc_coverage
# on specifies the build triggers. See more info at https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows
# The default is to run the workflow on every push or pull request to every branch.
on: [push, pull_request]
jobs:
  call-workflow:
    uses: nmfs-fish-tools/ghactions4r/.github/workflows/calc-coverage.yml@main
    with:
      use-public-rspm: false

For testing purposes before this PR is merged in, use the branch fix-calc-cov instead of main.

@Andrea-Havron-NOAA, when you are back, could you test and see if this solves the failing clustTMB calc coverage workflow?

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@k-doering-NOAA
Copy link
Collaborator Author

@Andrea-Havron-NOAA just a reminder about this!

@Andrea-Havron-NOAA
Copy link

Thanks for the reminder @k-doering-NOAA. I tested this on my clustTMB package and the calc-coverage workflow is passing again. Thanks for this fix!

@k-doering-NOAA
Copy link
Collaborator Author

Thanks @Andrea-Havron-NOAA ! Merging into main.

@k-doering-NOAA k-doering-NOAA merged commit e133132 into main Feb 29, 2024
10 checks passed
@k-doering-NOAA k-doering-NOAA deleted the fix-calc-cov branch February 29, 2024 17:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants