Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Issue 126: deprecate style only, style description only, and document only workflows #131

Merged
merged 4 commits into from
Jul 15, 2024

Conversation

k-doering-NOAA
Copy link
Collaborator

Addresses #126. This PR:

Users of these reusable workflows should instead use the doc-and-style-r reusable workflow, which can be set up using ghactions4r::use_style_and_document()

I think a remaining step that I should take would be to post an issue on repositories that are using this workflow, as I'm not sure the warnings are visible enough:
example of a warning

@iantaylor-NOAA would you be able to review this within the next week? If not, I can see if @kellijohnson-NOAA or @Bai-Li-NOAA are available.

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.47%. Comparing base (efda7e9) to head (690f245).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   92.62%   95.47%   +2.85%     
==========================================
  Files           3        3              
  Lines         217      199      -18     
==========================================
- Hits          201      190      -11     
+ Misses         16        9       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iantaylor-NOAA iantaylor-NOAA self-requested a review July 12, 2024 23:06
Copy link
Collaborator

@iantaylor-NOAA iantaylor-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for working on this @k-doering-NOAA.

I agree with the idea of posting issues on the repos that use those packages (shouldn't take long with boilerplate language).

The only question I have is whether it would be better to replace "will soon be deprecated" with something like "will be deprecated on 1 Oct 2024" (or whatever other specific date you want).

Also, when you do deprecate the workflows, would it lead to a failed github action, or just no action taking place?

@k-doering-NOAA
Copy link
Collaborator Author

@iantaylor-NOAA thanks so much for getting to this so quickly.

good point about adding a date! I'll make it December (unless @Bai-Li-NOAA is ok with removing them while I'm out, and I can let her pick the date :) )

I'm planning on just deleting the reusable workflows, which should cause the github actions to fail

I'll leave this open until I've posted on the repos that are using the workflows and the deprecation date has been added.

@iantaylor-NOAA
Copy link
Collaborator

@k-doering-NOAA, sounds good. December is fine.
I just updated one of the repos by running ghactions4r::use_r_cmd_check(), ghactions4r::use_doc_and_style_r(), and deleting old files which only took about 2 minutes: pfmc-assessments/PEPtools@10eddd1.

iantaylor-NOAA added a commit to pfmc-assessments/PEPtools that referenced this pull request Jul 12, 2024
I changed the github workflow that updated documentation with one that does all that as well as style the code (as discussed in nmfs-fish-tools/ghactions4r#131). So now we have nicely styled code.
k-doering-NOAA added a commit to ss3sim/ss3sim that referenced this pull request Jul 15, 2024
k-doering-NOAA added a commit to NOAA-FIMS/r4MAS that referenced this pull request Jul 15, 2024
k-doering-NOAA added a commit to nmfs-fish-tools/projectstats that referenced this pull request Jul 15, 2024
k-doering-NOAA added a commit to k-doering-NOAA/nwfscSurvey that referenced this pull request Jul 15, 2024
k-doering-NOAA added a commit to k-doering-NOAA/PacFIN.Utilities that referenced this pull request Jul 15, 2024
k-doering-NOAA added a commit to k-doering-NOAA/spmR that referenced this pull request Jul 15, 2024
@k-doering-NOAA
Copy link
Collaborator Author

@k-doering-NOAA k-doering-NOAA merged commit 2695d1a into main Jul 15, 2024
10 checks passed
@k-doering-NOAA k-doering-NOAA deleted the issue_126 branch July 15, 2024 16:15
kellijohnson-NOAA pushed a commit to nmfs-fish-tools/projectstats that referenced this pull request Jul 16, 2024
Replace update-docs with doc and style workflow

update-docs only will soon be deprecated by
nmfs-fish-tools/ghactions4r#131
Allow workflow on main branch
kellijohnson-NOAA pushed a commit to ss3sim/ss3sim that referenced this pull request Jul 17, 2024
Will be deprecated by nmfs-fish-tools/ghactions4r#131

Both of these workflows that are being removed occur in a combined workflow that is also being called and will continue to be called, i.e., doc-style so there is no need to replace these deprecated workflows.

Thanks @k-doering-NOAA!
kellijohnson-NOAA pushed a commit to pfmc-assessments/pacfintools that referenced this pull request Jul 17, 2024
kellijohnson-NOAA pushed a commit to NOAA-FIMS/r4MAS that referenced this pull request Oct 25, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants