-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Issue 126: deprecate style only, style description only, and document only workflows #131
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
==========================================
+ Coverage 92.62% 95.47% +2.85%
==========================================
Files 3 3
Lines 217 199 -18
==========================================
- Hits 201 190 -11
+ Misses 16 9 -7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for working on this @k-doering-NOAA.
I agree with the idea of posting issues on the repos that use those packages (shouldn't take long with boilerplate language).
The only question I have is whether it would be better to replace "will soon be deprecated" with something like "will be deprecated on 1 Oct 2024" (or whatever other specific date you want).
Also, when you do deprecate the workflows, would it lead to a failed github action, or just no action taking place?
@iantaylor-NOAA thanks so much for getting to this so quickly. good point about adding a date! I'll make it December (unless @Bai-Li-NOAA is ok with removing them while I'm out, and I can let her pick the date :) ) I'm planning on just deleting the reusable workflows, which should cause the github actions to fail I'll leave this open until I've posted on the repos that are using the workflows and the deprecation date has been added. |
@k-doering-NOAA, sounds good. December is fine. |
I changed the github workflow that updated documentation with one that does all that as well as style the code (as discussed in nmfs-fish-tools/ghactions4r#131). So now we have nicely styled code.
Will be deprecated by nmfs-fish-tools/ghactions4r#131
style only will soon be deprecated: nmfs-fish-tools/ghactions4r#131
update-docs only will soon be deprecated by nmfs-fish-tools/ghactions4r#131
update-docs only will soon be deprecated by nmfs-fish-tools/ghactions4r#131
documenting only workflow will soon be deprecated by nmfs-fish-tools/ghactions4r#131. Instead, use [doc and style workflow](https://nmfs-fish-tools.github.io/ghactions4r/reference/use_doc_and_style_r.html)
update-docs/style only workflows will soon be deprecated by nmfs-fish-tools/ghactions4r#131. Instead, use [style and document workflow](https://nmfs-fish-tools.github.io/ghactions4r/reference/use_doc_and_style_r.html)
Opened PRs to replace style or document only workflows with style and document workflow on the following https://github.com/afsc-assessments/spmR, https://github.com/nmfs-fish-tools/projectstats, https://github.com/pfmc-assessments/PacFIN.Utilities, https://github.com/ss3sim/ss3sim, https://github.com/pfmc-assessments/nwfscSurvey, https://github.com/nmfs-fish-tools/r4MAS. Those were the only remaining repos using these workflows. |
Replace update-docs with doc and style workflow update-docs only will soon be deprecated by nmfs-fish-tools/ghactions4r#131 Allow workflow on main branch
Will be deprecated by nmfs-fish-tools/ghactions4r#131 Both of these workflows that are being removed occur in a combined workflow that is also being called and will continue to be called, i.e., doc-style so there is no need to replace these deprecated workflows. Thanks @k-doering-NOAA!
documenting only workflow will soon be deprecated by nmfs-fish-tools/ghactions4r#131. Instead, use [doc and style workflow](https://nmfs-fish-tools.github.io/ghactions4r/reference/use_doc_and_style_r.html)
style only will soon be deprecated: nmfs-fish-tools/ghactions4r#131
Addresses #126. This PR:
Users of these reusable workflows should instead use the doc-and-style-r reusable workflow, which can be set up using
ghactions4r::use_style_and_document()
I think a remaining step that I should take would be to post an issue on repositories that are using this workflow, as I'm not sure the warnings are visible enough:

@iantaylor-NOAA would you be able to review this within the next week? If not, I can see if @kellijohnson-NOAA or @Bai-Li-NOAA are available.