テストが通るよう修正、ソースマップを追加、空配列の偽扱いを修正、候補が空の際に確認を追加、予定削除時に確認を追加 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
May 25, 2023 03:41
なお、出欠変更とコメント変更にはそもそもCSRF対策がされていないが、今回はめんどいのでスルーする
予定に候補日程や出欠表明者が既に存在する場合、その数も表示する。 テストは、`window.confirm()` を直接テストするのがめちゃくそ面倒（無理かも）なので、今回は削除ボタンの `data` 属性のテストで妥協。
|
コードが上手く動かない！そういう時こそ深い学びが得られるチャンスなので頑張ってその試練を乗り越えましょう！ |
TakkyZukky
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
window.confirm()を直接テストするのが異常に大変（無理かも）なので諦め。window.confirm()を直接テストするのが異常に大変（無理かも）なので、今回は削除ボタンのdata属性のテストで妥協。プルリクのテストなのでマージは不要です