Add files via upload #17
Conversation
There was a problem hiding this comment.
@btang1 Need to revert and bring back all my canopy changes in the updated ASX_DATA_MOD.F here.
|
I update ASX_DATA_MOD and Vdiffaxmx |
| @@ -837,7 +838,7 @@ subroutine get_dust_emis( jdate, jtime, tstep, rjacm, cellhgt, | |||
|
|
|||
| rlay1hgt = rjacm ( c,r ) / cellhgt | |||
|
|
|||
| dust_em( c,r ) = dust_alpha * vflux * rlay1hgt *tfa(c,r) * tfb(c,r) | |||
| dust_em( c,r ) = dust_alpha * vflux * rlay1hgt! *tfa(c,r) * tfb(c,r) | |||
There was a problem hiding this comment.
"*tfa(c,r) * tfb(c,r) " removed. Are you sure?
There was a problem hiding this comment.
because tfa and tfb not calculated in the code, so not able to call them here
|
Could you fill the following items? Description Have you tested running these changes or just compiled it on Orion? |
src/model/src/vdiffacmx.F
Outdated
There was a problem hiding this comment.
This file has many changes brought by CMAQ 5.4+. It is better to highlight the key changes.
There was a problem hiding this comment.
sure! let me work on it
There was a problem hiding this comment.
compiled vdiffacmx, it compiled without error after I turn off a 'end do' sentence.
comment a 'end do', after that, code compiled successfully
turn on according changed codes in local src/ folder
all codes I changed have successfully compiled in Orion. I have not run CMAQ online yet. Only compile without error. |
There was a problem hiding this comment.
Seems we could approve for now, but there are a lot of changes to vdiffacmx.F, as expected. However, seems you have added pieces to the old CMAQv5.2.1, rather than remove pieces from CMAQv5.4 version. I may be OK with either approach, but careful checking may be needed to evaluate if it makes sense. Also there are numerous places that the bi-directional NH3 dep is removed, and wonder why? Please elaborate.
| END DO | ||
|
|
||
| DO V = 1, N_SPC_DEPV | ||
| DDEP( V,C,R ) = DDBF( V ) | ||
| END DO | ||
|
|
||
| IF ( ABFLUX ) THEN |
There was a problem hiding this comment.
@btang1 Why is this removed?
| C --------- END of HET HONO RX ---------- | ||
|
|
||
| ELSE | ||
| S = DV2DF( V ) | ||
| CONC( S,1 ) = POL( V ) + ( CONC( S,1 ) - POL( V ) ) * EFAC2( V ) | ||
| DDBF( V ) = DDBF( V ) + THBAR * DD_FAC( V ) * CONC( S,1 ) |
|
|
||
| IF ( ABFLUX .AND. V .EQ. NH3_HIT ) THEN |
|
Hi Youhua,
I have summarized major changes for vdiffacmx. F in the attached file:
Best wishes,
Beiming
On Aug 29, 2023, at 12:27 PM, Youhua Tang ***@***.***> wrote:
Could you fill the following items?
Description
Issue(s) addressed
Have you tested running these changes or just compiled it on Orion?
—
Reply to this email directly, view it on GitHub<#17 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMGOO66O3LO3XBKA225TOMLXXYJ7LANCNFSM6AAAAAA3JEYK6U>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
PR Checklist
This PR has been tested on an RDHPCS machine and/or WCOSS2. Please select below:
This PR has been tested with the ufs-srweather-app workflow online-cmaq branch.
New or updated input data is required by this PR.
Baselines are expected to change.
Description
Issue(s) addressed
Dependencies