feat: blacklist e2e tests for fiattokenfactory #370

boojamya · 2024-05-27T20:39:57Z

Includes:

TestFiatTFUpdateBlacklister
TestFiatTFBlacklist
TestFiatTFUnblacklist

coderabbitai · 2024-05-27T20:40:02Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

xngln · 2024-06-25T02:58:28Z

e2e/fiat_tf_test.go

+		},
+	}
+	require.Equal(t, expectedGetBlacklisterResponse.Blacklister, showBlacklisterRes.Blacklister)
+}


Can we add a happy path test?

Added in: 06a3995 (#370)

xngln · 2024-06-25T03:00:54Z

e2e/fiat_tf_test.go

+
+	pauseFiatTF(t, ctx, val, nw.fiatTfRoles.Pauser)
+
+	blacklistAccount(t, ctx, val, nw.fiatTfRoles.Blacklister, toBlacklist1)


Missing verification that toBlacklist1 has been successfully blacklisted

Hi @xngln , we do this check in the blacklistAccount function:

noble/e2e/utils.go

Lines 392 to 402 in 149a7f6

var showBlacklistedResponse fiattokenfactorytypes.QueryGetBlacklistedResponse

err = json.Unmarshal(res, &showBlacklistedResponse)

require.NoError(t, err, "failed to unmarshal show-blacklisted response")

expectedBlacklistResponse := fiattokenfactorytypes.QueryGetBlacklistedResponse{

Blacklisted: fiattokenfactorytypes.Blacklisted{

AddressBz: toBlacklist.Address(),

},

}

require.Equal(t, expectedBlacklistResponse.Blacklisted, showBlacklistedResponse.Blacklisted)

xngln · 2024-06-25T03:05:42Z

e2e/fiat_tf_test.go

+	require.NoError(t, err, "failed to query list-blacklisted")
+
+	var preFailedBlacklist, postFailedBlacklist fiattokenfactorytypes.QueryAllBlacklistedResponse
+	_ = json.Unmarshal(res, &preFailedBlacklist)


Just to be extra thorough, could we also verify that preFailedBlacklist does not contain toBlacklist2?

Add in: b634d34 (#370)

xngln · 2024-06-25T03:08:35Z

e2e/fiat_tf_test.go

+
+	blacklistAccount(t, ctx, val, nw.fiatTfRoles.Blacklister, nw.fiatTfRoles.Blacklister)
+
+	blacklistAccount(t, ctx, val, nw.fiatTfRoles.Blacklister, toBlacklist2)


missing verification that toBlacklist2 is successfully blacklisted

See: #370 (comment)

xngln · 2024-06-25T03:08:52Z

e2e/fiat_tf_test.go

+		},
+	}
+	require.Equal(t, expectedBlacklistResponse.Blacklisted, showBlacklistedRes.Blacklisted)
+}


Can we add a happy path test here too?

Added in: 06a3995 (#370)

xngln · 2024-06-25T03:11:39Z

e2e/fiat_tf_test.go

+
+	pauseFiatTF(t, ctx, val, nw.fiatTfRoles.Pauser)
+
+	unblacklistAccount(t, ctx, val, nw.fiatTfRoles.Blacklister, blacklistedUser1)


missing verification that blacklistedUser1 is unblacklisted

We do this check inside of the unblacklistAccount function:

noble/e2e/utils.go

Lines 411 to 412 in 149a7f6

_, _, err = val.ExecQuery(ctx, "fiat-tokenfactory", "show-blacklisted", unBlacklist.FormattedAddress())

require.Error(t, err, "query succeeded, blacklisted account should not exist")

xngln · 2024-06-25T03:14:39Z

e2e/fiat_tf_test.go

+
+	blacklistAccount(t, ctx, val, nw.fiatTfRoles.Blacklister, nw.fiatTfRoles.Blacklister)
+
+	unblacklistAccount(t, ctx, val, nw.fiatTfRoles.Blacklister, blacklistedUser1)


missing verification that blacklistedUser is unblacklisted

See: #370 (comment)

xngln · 2024-06-25T03:18:44Z

e2e/fiat_tf_test.go

+
+	_, err = showBlacklisted(ctx, val, blacklistedUser1)
+	require.Error(t, err, "query succeeded, blacklisted account should not exist")
+}


Can we add the happy path test?

Added in: 06a3995 (#370)

Co-authored-by: Dan Kanefsky <dan@noble.xyz>

johnletey

LGTM! Passing on Cosmos SDK v0.50 ⚡

✅ Green CI for TestFiatTFUpdateBlacklister (link)
✅ Green CI for TestFiatTFBlacklist (link)
✅ Green CI for TestFiatTFUnblacklist (link)

boojamya added the token factory label May 27, 2024

johnletey mentioned this pull request May 30, 2024

EPIC: Upgrade to Cosmos SDK v0.50 #377

Closed

7 tasks

xngln reviewed Jun 25, 2024

View reviewed changes

kaliweh-circle approved these changes Jul 22, 2024

View reviewed changes

johnletey changed the base branch from feat/sdk-eden to main October 17, 2024 09:15

johnletey requested a review from a team as a code owner October 17, 2024 09:15

feat: blacklist e2e tests for fiattokenfactory

834fd2e

Co-authored-by: Dan Kanefsky <dan@noble.xyz>

johnletey force-pushed the dan/fiat-tf-blacklist branch from 06a3995 to 834fd2e Compare October 17, 2024 09:16

johnletey approved these changes Oct 17, 2024

View reviewed changes

johnletey changed the title ~~chore: blacklist E2E tests for fiat token factory~~ feat: blacklist e2e tests for fiattokenfactory Oct 17, 2024

johnletey merged commit 8664bcf into main Oct 17, 2024
26 checks passed

johnletey deleted the dan/fiat-tf-blacklist branch October 17, 2024 09:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: blacklist e2e tests for fiattokenfactory #370

feat: blacklist e2e tests for fiattokenfactory #370

boojamya commented May 27, 2024

coderabbitai bot commented May 27, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

xngln Jun 25, 2024

boojamya Jul 8, 2024

xngln Jun 25, 2024

boojamya Jul 8, 2024 •

edited

Loading

xngln Jun 25, 2024

boojamya Jul 8, 2024

xngln Jun 25, 2024

boojamya Jul 8, 2024

xngln Jun 25, 2024

boojamya Jul 8, 2024

xngln Jun 25, 2024

boojamya Jul 8, 2024

xngln Jun 25, 2024

boojamya Jul 8, 2024

xngln Jun 25, 2024

boojamya Jul 8, 2024

johnletey left a comment


		pauseFiatTF(t, ctx, val, nw.fiatTfRoles.Pauser)

		blacklistAccount(t, ctx, val, nw.fiatTfRoles.Blacklister, toBlacklist1)

	var showBlacklistedResponse fiattokenfactorytypes.QueryGetBlacklistedResponse
	err = json.Unmarshal(res, &showBlacklistedResponse)
	require.NoError(t, err, "failed to unmarshal show-blacklisted response")

	expectedBlacklistResponse := fiattokenfactorytypes.QueryGetBlacklistedResponse{
	Blacklisted: fiattokenfactorytypes.Blacklisted{
	AddressBz: toBlacklist.Address(),
	},
	}

	require.Equal(t, expectedBlacklistResponse.Blacklisted, showBlacklistedResponse.Blacklisted)


		pauseFiatTF(t, ctx, val, nw.fiatTfRoles.Pauser)

		unblacklistAccount(t, ctx, val, nw.fiatTfRoles.Blacklister, blacklistedUser1)

	_, _, err = val.ExecQuery(ctx, "fiat-tokenfactory", "show-blacklisted", unBlacklist.FormattedAddress())
	require.Error(t, err, "query succeeded, blacklisted account should not exist")

feat: blacklist e2e tests for fiattokenfactory #370

feat: blacklist e2e tests for fiattokenfactory #370

Conversation

boojamya commented May 27, 2024

coderabbitai bot commented May 27, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

boojamya Jul 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johnletey left a comment

Choose a reason for hiding this comment

coderabbitai bot commented May 27, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

boojamya Jul 8, 2024 •

edited

Loading