exposing file writable stream errors (from #316) #520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanks to #316 by @gabipetrovay, closes #469, possible fix #470 too Co-authored-by: gabipetrovay
|
Yea... of course, it breaks the "legacy" tests :D |
|
Okay, i don't get it. Even with But in anyway... everything boils down back to that we should rewrite tests without stubbing and gently. I'm presonally not fan of stubs. |
tunnckoCore
requested review from
Amit-A,
GrosSacASac,
kornelski,
quantumsheep and
xarguments
GrosSacASac
approved these changes
Nov 28, 2019
quantumsheep
reviewed
Dec 7, 2019
| @@ -31,7 +31,11 @@ module.exports = File; | |||
| util.inherits(File, EventEmitter); | |||
|
|
|||
| File.prototype.open = function() { | |||
| var self = this; | |||
There was a problem hiding this comment.
Maybe we can use an array function here to omit using a self variable?
|
closing in b70bb80 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thanks to #316 by @gabipetrovay, closes #469, possible fix #470 too
tip on merge: add
Co-authored-by: Gabriel Petrovay <gabipetrovay@gmail.com>